Posted by socket on 21:34:00 12-28-2002
i've written a small winapi program that converts unix text files to windows text files and the other way around...
it's written in c ... and you can check it out in http://tfc666.sourceforge.net
i'd love to get your opinion about the code and any pointers on how to improve it...
thanks in advance,
socket
[ This Message was edited by: socket on 2002-12-28 21:35 ]
Posted by KaGez on 01:05:00 12-29-2002
ok, I've got a few things to say about it . First, the GUI looks awsome. Honestly. OK, it may be a small one, but it's clean, ordered, and easy to understand imho.
Second:
I always thought that header files were to put prototypes and various other declerations and such into. As most people do this, and (for me) it was quite confusing (I had some trouble finding the unix2win functions in tfc.c ) when I found the core functions of the program in the header file (tfc.h).
The rest look pretty ok to me
Maybe commenting the "inner" of the function would be cool too
[addsig]
Posted by socket on 01:25:00 12-29-2002
thanks, im glad you liked it
i've separated the conversion functions from tfc.c beacause it only handles the gui.
and also the linux port of tfc uses the same conversion routines so it was more comfortable for me to use the same header for both versions (does this make sense? )
about the commenting, i'll see what i can do
[ This Message was edited by: socket on 2002-12-29 01:25 ]
Posted by KaGez on 01:35:00 12-29-2002
ahhh, now it makes more sence that it is in a different file, but still not much more sence why it is a header file
I don't care what is where, as long as I can find it tho
And, in this case, where the program is quite compact, I think it doesn't really matter if it is a c or h file now. I just wanted to say it
[addsig]